From edf385e59717f7b421d91462fcea71830eb23149 Mon Sep 17 00:00:00 2001 From: Tulio A M Mendes Date: Sun, 8 Feb 2026 04:24:04 -0300 Subject: [PATCH] cppcheck: const cleanups (full vfs api) --- include/fs.h | 6 +++--- src/drivers/initrd.c | 2 +- src/kernel/devfs.c | 8 ++++---- src/kernel/fs.c | 2 +- src/kernel/overlayfs.c | 6 +++--- src/kernel/syscall.c | 2 +- src/kernel/tmpfs.c | 8 ++++---- 7 files changed, 17 insertions(+), 17 deletions(-) diff --git a/include/fs.h b/include/fs.h index d03e54d..16b9adc 100644 --- a/include/fs.h +++ b/include/fs.h @@ -17,15 +17,15 @@ typedef struct fs_node { // Function pointers for operations (Polymorphism in C) uint32_t (*read)(struct fs_node* node, uint32_t offset, uint32_t size, uint8_t* buffer); - uint32_t (*write)(struct fs_node* node, uint32_t offset, uint32_t size, uint8_t* buffer); + uint32_t (*write)(struct fs_node* node, uint32_t offset, uint32_t size, const uint8_t* buffer); void (*open)(struct fs_node* node); void (*close)(struct fs_node* node); - struct fs_node* (*finddir)(struct fs_node* node, char* name); + struct fs_node* (*finddir)(struct fs_node* node, const char* name); } fs_node_t; // Standard VFS functions uint32_t vfs_read(fs_node_t* node, uint32_t offset, uint32_t size, uint8_t* buffer); -uint32_t vfs_write(fs_node_t* node, uint32_t offset, uint32_t size, uint8_t* buffer); +uint32_t vfs_write(fs_node_t* node, uint32_t offset, uint32_t size, const uint8_t* buffer); void vfs_open(fs_node_t* node); void vfs_close(fs_node_t* node); diff --git a/src/drivers/initrd.c b/src/drivers/initrd.c index 50c8ede..2148eb5 100644 --- a/src/drivers/initrd.c +++ b/src/drivers/initrd.c @@ -178,7 +178,7 @@ static uint32_t initrd_read_impl(fs_node_t* node, uint32_t offset, uint32_t size return size; } -static struct fs_node* initrd_finddir(struct fs_node* node, char* name) { +static struct fs_node* initrd_finddir(struct fs_node* node, const char* name) { if (!node || !name) return 0; int parent = (int)node->inode; if (parent < 0 || parent >= entry_count) return 0; diff --git a/src/kernel/devfs.c b/src/kernel/devfs.c index 884cc28..e7b356b 100644 --- a/src/kernel/devfs.c +++ b/src/kernel/devfs.c @@ -21,7 +21,7 @@ static uint32_t dev_null_read(fs_node_t* node, uint32_t offset, uint32_t size, u return 0; } -static uint32_t dev_null_write(fs_node_t* node, uint32_t offset, uint32_t size, uint8_t* buffer) { +static uint32_t dev_null_write(fs_node_t* node, uint32_t offset, uint32_t size, const uint8_t* buffer) { (void)node; (void)offset; (void)buffer; @@ -36,15 +36,15 @@ static uint32_t dev_tty_read(fs_node_t* node, uint32_t offset, uint32_t size, ui return (uint32_t)rc; } -static uint32_t dev_tty_write(fs_node_t* node, uint32_t offset, uint32_t size, uint8_t* buffer) { +static uint32_t dev_tty_write(fs_node_t* node, uint32_t offset, uint32_t size, const uint8_t* buffer) { (void)node; (void)offset; - int rc = tty_write_kbuf(buffer, size); + int rc = tty_write_kbuf((const uint8_t*)buffer, size); if (rc < 0) return 0; return (uint32_t)rc; } -static struct fs_node* devfs_finddir_impl(struct fs_node* node, char* name) { +static struct fs_node* devfs_finddir_impl(struct fs_node* node, const char* name) { (void)node; if (!name || name[0] == 0) return 0; diff --git a/src/kernel/fs.c b/src/kernel/fs.c index 5eccd63..bd4ed98 100644 --- a/src/kernel/fs.c +++ b/src/kernel/fs.c @@ -75,7 +75,7 @@ uint32_t vfs_read(fs_node_t* node, uint32_t offset, uint32_t size, uint8_t* buff return 0; } -uint32_t vfs_write(fs_node_t* node, uint32_t offset, uint32_t size, uint8_t* buffer) { +uint32_t vfs_write(fs_node_t* node, uint32_t offset, uint32_t size, const uint8_t* buffer) { if (node->write) return node->write(node, offset, size, buffer); return 0; diff --git a/src/kernel/overlayfs.c b/src/kernel/overlayfs.c index 25e3113..a03335e 100644 --- a/src/kernel/overlayfs.c +++ b/src/kernel/overlayfs.c @@ -21,7 +21,7 @@ struct overlay_node { char path[256]; }; -static struct fs_node* overlay_finddir_impl(struct fs_node* node, char* name); +static struct fs_node* overlay_finddir_impl(struct fs_node* node, const char* name); static void overlay_str_copy_n(char* dst, size_t dst_sz, const char* src, size_t src_n) { if (!dst || dst_sz == 0) return; @@ -71,7 +71,7 @@ static fs_node_t* overlay_copy_up_file(struct overlay_node* on) { return created; } -static uint32_t overlay_write_impl(fs_node_t* node, uint32_t offset, uint32_t size, uint8_t* buffer) { +static uint32_t overlay_write_impl(fs_node_t* node, uint32_t offset, uint32_t size, const uint8_t* buffer) { if (!node) return 0; struct overlay_node* on = (struct overlay_node*)node; @@ -142,7 +142,7 @@ static fs_node_t* overlay_wrap_child(struct overlay_node* parent, const char* na return &c->vfs; } -static struct fs_node* overlay_finddir_impl(struct fs_node* node, char* name) { +static struct fs_node* overlay_finddir_impl(struct fs_node* node, const char* name) { if (!node || !name) return 0; if (node->flags != FS_DIRECTORY) return 0; diff --git a/src/kernel/syscall.c b/src/kernel/syscall.c index c99711b..49dab83 100644 --- a/src/kernel/syscall.c +++ b/src/kernel/syscall.c @@ -285,7 +285,7 @@ static uint32_t pipe_read(fs_node_t* n, uint32_t offset, uint32_t size, uint8_t* return to_read; } -static uint32_t pipe_write(fs_node_t* n, uint32_t offset, uint32_t size, uint8_t* buffer) { +static uint32_t pipe_write(fs_node_t* n, uint32_t offset, uint32_t size, const uint8_t* buffer) { (void)offset; struct pipe_node* pn = (struct pipe_node*)n; if (!pn || !pn->ps || !buffer) return 0; diff --git a/src/kernel/tmpfs.c b/src/kernel/tmpfs.c index 601df79..db10d33 100644 --- a/src/kernel/tmpfs.c +++ b/src/kernel/tmpfs.c @@ -16,8 +16,8 @@ struct tmpfs_node { static uint32_t g_tmpfs_next_inode = 1; -static struct fs_node* tmpfs_finddir_impl(struct fs_node* node, char* name); -static uint32_t tmpfs_write_impl(fs_node_t* node, uint32_t offset, uint32_t size, uint8_t* buffer); +static struct fs_node* tmpfs_finddir_impl(struct fs_node* node, const char* name); +static uint32_t tmpfs_write_impl(fs_node_t* node, uint32_t offset, uint32_t size, const uint8_t* buffer); static struct tmpfs_node* tmpfs_node_alloc(const char* name, uint32_t flags) { struct tmpfs_node* n = (struct tmpfs_node*)kmalloc(sizeof(*n)); @@ -108,7 +108,7 @@ static uint32_t tmpfs_read_impl(fs_node_t* node, uint32_t offset, uint32_t size, return size; } -static uint32_t tmpfs_write_impl(fs_node_t* node, uint32_t offset, uint32_t size, uint8_t* buffer) { +static uint32_t tmpfs_write_impl(fs_node_t* node, uint32_t offset, uint32_t size, const uint8_t* buffer) { if (!node || !buffer) return 0; if (node->flags != FS_FILE) return 0; @@ -138,7 +138,7 @@ static uint32_t tmpfs_write_impl(fs_node_t* node, uint32_t offset, uint32_t size return size; } -static struct fs_node* tmpfs_finddir_impl(struct fs_node* node, char* name) { +static struct fs_node* tmpfs_finddir_impl(struct fs_node* node, const char* name) { if (!node || !name) return 0; if (node->flags != FS_DIRECTORY) return 0; -- 2.43.0