From: Tulio A M Mendes <tadryanom@hotmail.com>
Date: Tue, 10 Feb 2026 04:12:07 +0000 (-0300)
Subject: fix: implement real irq_save/irq_restore for ARM, RISC-V, MIPS
X-Git-Url: https://projects.tadryanom.me/docs/POSIX_ROADMAP.md?a=commitdiff_plain;h=72ab5d54f7d87abc8ff90b51242c44eaeb8b0104;p=AdrOS.git

fix: implement real irq_save/irq_restore for ARM, RISC-V, MIPS

spinlock.h had no-op irq_save/irq_restore for non-x86 architectures,
meaning spin_lock_irqsave would not actually disable interrupts on
ARM, RISC-V, or MIPS — breaking all critical sections.

Add proper implementations:
- ARM: mrs/msr CPSR with cpsid i
- RISC-V: csrrci/csrsi mstatus MIE bit
- MIPS: mfc0/di/ei on CP0 Status IE bit

Passes: make, cppcheck, QEMU smoke test.
---

diff --git a/include/spinlock.h b/include/spinlock.h
index 511465f..c10196b 100644
--- a/include/spinlock.h
+++ b/include/spinlock.h
@@ -45,14 +45,49 @@ static inline void irq_restore(uintptr_t flags) {
     __asm__ volatile ("push %0; popf" :: "r"(flags) : "memory", "cc");
 #endif
 }
-#else
+#elif defined(__arm__)
 static inline uintptr_t irq_save(void) {
-    return 0;
+    uintptr_t cpsr;
+    __asm__ volatile("mrs %0, cpsr\n\tcpsid i" : "=r"(cpsr) :: "memory");
+    return cpsr;
 }
 
 static inline void irq_restore(uintptr_t flags) {
-    (void)flags;
+    __asm__ volatile("msr cpsr_c, %0" :: "r"(flags) : "memory");
 }
+
+#elif defined(__riscv)
+static inline uintptr_t irq_save(void) {
+    uintptr_t mstatus;
+    __asm__ volatile("csrrci %0, mstatus, 0x8" : "=r"(mstatus) :: "memory");
+    return mstatus & 0x8;
+}
+
+static inline void irq_restore(uintptr_t flags) {
+    if (flags) {
+        __asm__ volatile("csrsi mstatus, 0x8" ::: "memory");
+    }
+}
+
+#elif defined(__mips__)
+static inline uintptr_t irq_save(void) {
+    uintptr_t status;
+    __asm__ volatile(
+        "mfc0 %0, $12\n\t"
+        "di"
+        : "=r"(status) :: "memory");
+    return status & 1U;
+}
+
+static inline void irq_restore(uintptr_t flags) {
+    if (flags) {
+        __asm__ volatile("ei" ::: "memory");
+    }
+}
+
+#else
+static inline uintptr_t irq_save(void) { return 0; }
+static inline void irq_restore(uintptr_t flags) { (void)flags; }
 #endif
 
 static inline uintptr_t spin_lock_irqsave(spinlock_t* l) {