cppcheck: const cleanups (full vfs api)

diff --git a/include/fs.h b/include/fs.h
index 0dfbfa39d5e4ddfcbea32d9b18b5f300487e3247..11761e7b4f41c90acd327809f7651425aab29d33 100644 (file)
--- a/include/fs.h
+++ b/include/fs.h
@@ -26,15 +26,15 @@ typedef struct fs_node {
     
     // Function pointers for operations (Polymorphism in C)
     uint32_t (*read)(struct fs_node* node, uint32_t offset, uint32_t size, uint8_t* buffer);
-    uint32_t (*write)(struct fs_node* node, uint32_t offset, uint32_t size, uint8_t* buffer);
+    uint32_t (*write)(struct fs_node* node, uint32_t offset, uint32_t size, const uint8_t* buffer);
     void (*open)(struct fs_node* node);
     void (*close)(struct fs_node* node);
-    struct fs_node* (*finddir)(struct fs_node* node, char* name);
+    struct fs_node* (*finddir)(struct fs_node* node, const char* name);
 } fs_node_t;
 
 // Standard VFS functions
 uint32_t vfs_read(fs_node_t* node, uint32_t offset, uint32_t size, uint8_t* buffer);
-uint32_t vfs_write(fs_node_t* node, uint32_t offset, uint32_t size, uint8_t* buffer);
+uint32_t vfs_write(fs_node_t* node, uint32_t offset, uint32_t size, const uint8_t* buffer);
 void vfs_open(fs_node_t* node);
 void vfs_close(fs_node_t* node);
 

diff --git a/src/drivers/initrd.c b/src/drivers/initrd.c
index 4499b95ebdd0a01439b01064d61dce3ca89bebe0..0e884e1ac74f1c08f10278d93b55e9d4711e9e5e 100644 (file)
--- a/src/drivers/initrd.c
+++ b/src/drivers/initrd.c
@@ -187,7 +187,7 @@ static uint32_t initrd_read_impl(fs_node_t* node, uint32_t offset, uint32_t size
     return size;
 }
 
-static struct fs_node* initrd_finddir(struct fs_node* node, char* name) {
+static struct fs_node* initrd_finddir(struct fs_node* node, const char* name) {
     if (!node || !name) return 0;
     int parent = (int)node->inode;
     if (parent < 0 || parent >= entry_count) return 0;

diff --git a/src/kernel/devfs.c b/src/kernel/devfs.c
index cbffe7b5fb6bb9796a0470fa2c4b59e21f94d176..9d51e1b6e78984d3fd1dae4ab6079ab8ace1e938 100644 (file)
--- a/src/kernel/devfs.c
+++ b/src/kernel/devfs.c
@@ -30,7 +30,7 @@ static uint32_t dev_null_read(fs_node_t* node, uint32_t offset, uint32_t size, u
     return 0;
 }
 
-static uint32_t dev_null_write(fs_node_t* node, uint32_t offset, uint32_t size, uint8_t* buffer) {
+static uint32_t dev_null_write(fs_node_t* node, uint32_t offset, uint32_t size, const uint8_t* buffer) {
     (void)node;
     (void)offset;
     (void)buffer;
@@ -45,15 +45,15 @@ static uint32_t dev_tty_read(fs_node_t* node, uint32_t offset, uint32_t size, ui
     return (uint32_t)rc;
 }
 
-static uint32_t dev_tty_write(fs_node_t* node, uint32_t offset, uint32_t size, uint8_t* buffer) {
+static uint32_t dev_tty_write(fs_node_t* node, uint32_t offset, uint32_t size, const uint8_t* buffer) {
     (void)node;
     (void)offset;
-    int rc = tty_write_kbuf(buffer, size);
+    int rc = tty_write_kbuf((const uint8_t*)buffer, size);
     if (rc < 0) return 0;
     return (uint32_t)rc;
 }
 
-static struct fs_node* devfs_finddir_impl(struct fs_node* node, char* name) {
+static struct fs_node* devfs_finddir_impl(struct fs_node* node, const char* name) {
     (void)node;
     if (!name || name[0] == 0) return 0;
 

diff --git a/src/kernel/fs.c b/src/kernel/fs.c
index 43fe25234ada6c72fe5c67ddf84a6686d6862ad3..0be2b4f8be994a98bd97784e5344744cfcc63fac 100644 (file)
--- a/src/kernel/fs.c
+++ b/src/kernel/fs.c
@@ -84,7 +84,7 @@ uint32_t vfs_read(fs_node_t* node, uint32_t offset, uint32_t size, uint8_t* buff
     return 0;
 }
 
-uint32_t vfs_write(fs_node_t* node, uint32_t offset, uint32_t size, uint8_t* buffer) {
+uint32_t vfs_write(fs_node_t* node, uint32_t offset, uint32_t size, const uint8_t* buffer) {
     if (node->write)
         return node->write(node, offset, size, buffer);
     return 0;

diff --git a/src/kernel/overlayfs.c b/src/kernel/overlayfs.c
index fedbe3a0fb970cc0c00ad16b85e2da503e087bc3..bf80073207cb4d2c18c4a5d3559acc5ccedb8161 100644 (file)
--- a/src/kernel/overlayfs.c
+++ b/src/kernel/overlayfs.c
@@ -30,7 +30,7 @@ struct overlay_node {
     char path[256];
 };
 
-static struct fs_node* overlay_finddir_impl(struct fs_node* node, char* name);
+static struct fs_node* overlay_finddir_impl(struct fs_node* node, const char* name);
 
 static void overlay_str_copy_n(char* dst, size_t dst_sz, const char* src, size_t src_n) {
     if (!dst || dst_sz == 0) return;
@@ -80,7 +80,7 @@ static fs_node_t* overlay_copy_up_file(struct overlay_node* on) {
     return created;
 }
 
-static uint32_t overlay_write_impl(fs_node_t* node, uint32_t offset, uint32_t size, uint8_t* buffer) {
+static uint32_t overlay_write_impl(fs_node_t* node, uint32_t offset, uint32_t size, const uint8_t* buffer) {
     if (!node) return 0;
     struct overlay_node* on = (struct overlay_node*)node;
 
@@ -151,7 +151,7 @@ static fs_node_t* overlay_wrap_child(struct overlay_node* parent, const char* na
     return &c->vfs;
 }
 
-static struct fs_node* overlay_finddir_impl(struct fs_node* node, char* name) {
+static struct fs_node* overlay_finddir_impl(struct fs_node* node, const char* name) {
     if (!node || !name) return 0;
     if (node->flags != FS_DIRECTORY) return 0;
 

diff --git a/src/kernel/syscall.c b/src/kernel/syscall.c
index 4eed971af31df582d18cc95296108aa549668587..b7fc21efc9c157302ec09e2cb5694d3d9252c536 100644 (file)
--- a/src/kernel/syscall.c
+++ b/src/kernel/syscall.c
@@ -294,7 +294,7 @@ static uint32_t pipe_read(fs_node_t* n, uint32_t offset, uint32_t size, uint8_t*
     return to_read;
 }
 
-static uint32_t pipe_write(fs_node_t* n, uint32_t offset, uint32_t size, uint8_t* buffer) {
+static uint32_t pipe_write(fs_node_t* n, uint32_t offset, uint32_t size, const uint8_t* buffer) {
     (void)offset;
     struct pipe_node* pn = (struct pipe_node*)n;
     if (!pn || !pn->ps || !buffer) return 0;

diff --git a/src/kernel/tmpfs.c b/src/kernel/tmpfs.c
index ee366ca592abed4973658f96ae977d5b2c9fc38b..700785cbb3b434591598c4f0adfcb29108f8ed6b 100644 (file)
--- a/src/kernel/tmpfs.c
+++ b/src/kernel/tmpfs.c
@@ -25,8 +25,8 @@ struct tmpfs_node {
 
 static uint32_t g_tmpfs_next_inode = 1;
 
-static struct fs_node* tmpfs_finddir_impl(struct fs_node* node, char* name);
-static uint32_t tmpfs_write_impl(fs_node_t* node, uint32_t offset, uint32_t size, uint8_t* buffer);
+static struct fs_node* tmpfs_finddir_impl(struct fs_node* node, const char* name);
+static uint32_t tmpfs_write_impl(fs_node_t* node, uint32_t offset, uint32_t size, const uint8_t* buffer);
 
 static struct tmpfs_node* tmpfs_node_alloc(const char* name, uint32_t flags) {
     struct tmpfs_node* n = (struct tmpfs_node*)kmalloc(sizeof(*n));
@@ -117,7 +117,7 @@ static uint32_t tmpfs_read_impl(fs_node_t* node, uint32_t offset, uint32_t size,
     return size;
 }
 
-static uint32_t tmpfs_write_impl(fs_node_t* node, uint32_t offset, uint32_t size, uint8_t* buffer) {
+static uint32_t tmpfs_write_impl(fs_node_t* node, uint32_t offset, uint32_t size, const uint8_t* buffer) {
     if (!node || !buffer) return 0;
     if (node->flags != FS_FILE) return 0;
 
@@ -147,7 +147,7 @@ static uint32_t tmpfs_write_impl(fs_node_t* node, uint32_t offset, uint32_t size
     return size;
 }
 
-static struct fs_node* tmpfs_finddir_impl(struct fs_node* node, char* name) {
+static struct fs_node* tmpfs_finddir_impl(struct fs_node* node, const char* name) {
     if (!node || !name) return 0;
     if (node->flags != FS_DIRECTORY) return 0;